Skip to content

[gui] Add RTreeMap #19731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[gui] Add RTreeMap #19731

wants to merge 1 commit into from

Conversation

magnustymoteus
Copy link
Contributor

This Pull request:

Changes or fixes:

This PR adds a new directory treemap in /gui/ with the following features:

  • Logic for generating treemap
  • Drawing a treemap on a TVirtualPad
    • This is the non-interactive version without web graphics (interactive JS treemaps will be in a separate PR)
  • Importing the treemap given an RNTuple
  • CMakeLists.txt that makes this a root library ROOTTreeMap
    • Should this be renamed to ROOTTreeMapv7?
    • Should this file be moved to a separate "CMake integration" PR?
  • LinkDef.h so that the treemap structure can be encoded to JSON for use in JS

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

pcanal
pcanal reviewed Aug 22, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2025 •
edited
Loading

Test Results

    20 files      20 suites   3d 23h 44m 7s ⏱️
 3 648 tests  3 644 ✅   0 💤 4 ❌
71 278 runs  71 067 ✅ 207 💤 4 ❌

For more details on these failures, see this check.

Results for commit 09a2f55.

♻️ This comment has been updated with latest results.

silverweed
silverweed requested changes Aug 26, 2025
View reviewed changes
@magnustymoteus magnustymoteus force-pushed the treemap-c++ branch 2 times, most recently from 3bce25d to cde8a6a Compare August 26, 2025 15:14
silverweed
silverweed approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

silverweed
silverweed reviewed Aug 27, 2025
View reviewed changes
@magnustymoteus magnustymoteus force-pushed the treemap-c++ branch 2 times, most recently from 6443168 to ab807f9 Compare August 27, 2025 12:37
@magnustymoteus
Copy link
Contributor Author

Some changes I made:

  • Removed the clad thing from CMakeLists.txt
  • Additional static Import method with RNTupleInspector as argument (needed for the non-web TBrowser)
  • General code cleanup (e.g push -> emplace)

pcanal
pcanal reviewed Aug 27, 2025
View reviewed changes
pcanal
pcanal reviewed Aug 27, 2025
View reviewed changes
@magnustymoteus magnustymoteus force-pushed the treemap-c++ branch 2 times, most recently from 3b19020 to cd1ae96 Compare August 29, 2025 15:28
pcanal
pcanal reviewed Aug 29, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal left review comments

@silverweed silverweed silverweed approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@enirolf enirolf Awaiting requested review from enirolf

Assignees

@pcanal pcanal

Labels
in:GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magnustymoteus @pcanal @silverweed